[cmake-developers] Introduction and volunteering for the Matlab package
Raffi Enficiaud
raffi.enficiaud at free.fr
Thu Jan 22 10:13:47 EST 2015
Hi,
I added a section "known problems" in the documentation and removed the REDUCE_VISIBILITY option. I am keeping the hidden symbols of the compiled MEX file as it appears to be something properly supported. This behaviour is also documented.
I moved the test for bad configuration under RunCMake with appropriate error message and return code.
How do we proceed next?
Best,
Raffi Enficiaud
> On 21 Jan 2015, at 22:30, Brad King <brad.king at kitware.com> wrote:
>
> On 01/21/2015 12:01 PM, Raffi Enficiaud wrote:
>> Ok. What do you think about mimicking the mex compiler in terms
>> of options set to the compiler? The -Wl,--exclude-libs,ALL is in
>> fact set by the mex compiler for compiling the mex extensions under
>> Linux. Then I will just drop the REDUCE_VISIBILITY from the
>> interface and add some doc about the "best practices" that work better.
>
> I think suggesting it in the documentation is fine. If some common
> cross-platform solutions evolve then we can revisit adding official
> support.
>
>> But I have a quick question about the proper way of adding a test:
> [snip]
>> should fail because of a component lacking the the find_package option
>
> The best place to put tests covering bad CMake code and error cases
> is under the Tests/RunCMake infrastructure. That allows explicit
> matching of return codes and error messages.
>
> Thanks,
> -Brad
>
More information about the cmake-developers
mailing list