[cmake-developers] [PATCH] fix use of CMAKE_REQUIRED_DEFINITIONS
Brad King
brad.king at kitware.com
Tue Feb 24 09:47:12 EST 2015
On 02/24/2015 08:25 AM, Mark Abraham wrote:
> Some modules shoud use CMAKE_REQUIRED_FLAGS, not CMAKE_REQUIRED_DEFINITIONS, I think.
Actually both technically support any flags, but the latter
only for legacy reasons. I agree CMAKE_REQUIRED_FLAGS is
clearer for this purpose. I've applied the patch with
minor tweaks:
Check*CompilerFlag: Refactor method used to pass flags
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d5067ae
Thanks,
-Brad
More information about the cmake-developers
mailing list