[cmake-developers] [PATCH v5 0/4] Add XCTest Bundles Support

Brad King brad.king at kitware.com
Mon Feb 23 13:18:23 EST 2015


On 02/22/2015 01:00 PM, Gregor Jasny wrote:
> Changes since v4:
> * Added release notes
> * Use get_filename_component to sanitize paths
> * Moved and wires up XcodePlatformFrameworks test
> * Cleaned and wired up XCTest Test.

Thanks.  I've applied two of the changes with minor tweaks:

 OS X: Shorten CFBundleExecutable to file name only
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=78ec4b16

 OS X: Add platform-specific Frameworks search path
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0ee2a004

and merged to 'next' for testing.

The main two changes are pretty close but need a couple of tweaks.
Once the two above changes are in 'master' please rebase on them.

>     /module/Use_wxWindows
> +   /module/XCTestUtilities
>     /module/WriteBasicConfigVersionFile

This is not sorted.  X should be after W.

> +  if(XCODE_VERSION AND NOT "${XCODE_VERSION}" VERSION_LESS 5)
> +    add_subdirectory(XCTest)
> +  endif()

This wires the test into the build of CMake itself.  The other
cases nearby that hunk are adding subdirectories that themselves
call add_test (directly or otherwise).  In the case of XCTest
it should be added with ADD_TEST_MACRO or a manual add_test call
if necessary.

Thanks,
-Brad



More information about the cmake-developers mailing list