[cmake-developers] [PATCH] User may now specify toolset through CMake GUI

[Robert Dailey]

What would be the best way to handle detecting which generators support toolset?

The confusing piece I had to figure out last night is that there is
simply no "generator" base class from which everything derives, there
are 2 types: extra generators and generators. So far the best thing I
can think of is to add a new method to the cmake class to return a
list of strings of all generators (both extra and base generators)
that support toolsets. Then I would propagate this list up to QCMake
and then to the Initial setup dialog so that it can compare the
toolset selection with the contents of that string list.

Is there a better way, design-wise? I'm still learning the overall architecture.

On Mon, Feb 16, 2015 at 11:54 AM, Brad King <brad.king at kitware.com> wrote:
> On 02/16/2015 11:59 AM, Robert Dailey wrote:
>> What is the recommended practice for updating patches on mailing
>> lists? With pull requests it's easy because it picks up my changes I
>> push to my branch automatically. I think if I push another patch to
>> the mailing list it will start another email thread, which may cause
>> lost context since this email chain won't be connected to the new one
>> (not sure if that matters).
>
> Please squash the changes and send a revised patch.
>
> You can just use the normal "Reply" operation in your mailer
> and attach the patch.  You don't have to use "git send-email".
>
> If you do want to use "git send-email" then with "git format-patch"
> you can pass "-v 2 --in-reply-to='<Message-ID>'" where <Message-ID>
> is the value of the "Message-ID: ..." header field in the message
> to which you're replying.  That will keep it in the same thread.
>
> Thanks,
> -Brad
>