[cmake-developers] [PATCH] User may now specify toolset through CMake GUI

Clinton Stimpson clinton at elemtech.com
Mon Feb 16 12:28:02 EST 2015


On Monday, February 16, 2015 11:35:47 AM Brad King wrote:
> On 02/15/2015 03:27 PM, rcdailey.lists at gmail.com wrote:
> > From: Robert Dailey <rcdailey at gmail.com>
> > 
> > The -T parameter to CMake may now be specified through QtDialog
> > (cmake-gui) via a new text field in the first-time configure
> > wizard (below the generator chooser).
> 
> Thanks for working on this.  I think QCMake::setBinaryDirectory
> also needs to check for CMAKE_GENERATOR_TOOLSET from an existing
> cache file much like it already does for CMAKE_GENERATOR.  One
> may currently use the "Add Entry" button to pre-define an entry
> for CMAKE_GENERATOR_TOOLSET to set this from the GUI indirectly.
> 
> Since not all generators support this field, we should not present
> it when a non-supporting generator is selected.  This will need
> some type of query on the selected generator to be added.
> 
> Thanks,
> -Brad

In addition to Brad's comments, QCMake::deleteCache() should reset the Toolset 
member.

Thanks,
Clint


More information about the cmake-developers mailing list