[cmake-developers] Commit 4c98de33: cmLocalGenerator: fix the default configuration check

Ben Boeckel ben.boeckel at kitware.com
Mon Feb 2 18:35:17 EST 2015


On Mon, Feb 02, 2015 at 23:47:15 +0100, Roman Wüger wrote:
> I think the change is also required for the following line (line 424):
> 
>  
> 
> if(!default_config && !configurationTypes.empty())
> 
>  
> 
> Because here the ?default_config? could also be a valid pointer with an
> empty content/string.
> 
> Nevertheless I had already posted a working patch which uses a std::vector
> and std::string instead to prevent such pointer problems.

Yeah, your patch is better. I'll revert mine and put yours up. Do you
have/want access to the stage to push it yourself? I can do so if not.

    http://www.cmake.org/Wiki/CMake/Git/Develop

Thanks,

--Ben

P.S. Also, seems I hadn't switched this repo over to my Kitware email
anyways for this commit.


More information about the cmake-developers mailing list