[cmake-developers] Fwd: [CMake] CPack in CMake 3.1.0 doesn't install files

[Robert Maynard]

Forwarding to CMake Developers as this looks to be bug.


---------- Forwarded message ----------
From: NoRulez <norulez at me.com>
Date: Mon, Feb 2, 2015 at 9:54 AM
Subject: Re: [CMake] CPack in CMake 3.1.0 doesn't install files
To: Robert Maynard <robert.maynard at kitware.com>
Cc: CMake MailingList <cmake at cmake.org>


Hi,

I think I found the problem:
In the file cmLocalGenerator.cxx the pointer is always true since
3.1.0, which was a const char* in 3.0.2. and now it could point to an
empty const std::string, but the pointer is still valid

The if statement is:
if(!default_config)

And should be (line 411):
if(!default_config || (default_config && strlen(default_config) == 0))

Best Regards


> Am 23.01.2015 um 09:15 schrieb NoRulez <norulez at me.com>:
>
> Hi,
>
> i've tested it also with 3.1.1 and the failure behaves the same.
>
> Best Regards
>
>
>> Am 21.01.2015 um 10:00 schrieb NoRulez <norulez at me.com>:
>>
>> Hi,
>>
>> it should also not work when you build a test project in release mode and then in the build directory type "cpack -G ZIP" for example. (Without the -C option)
>>
>> In the CTestScript is also added the -C option to ensure it uses the release mode, but it doesn't work either.
>>
>> When you then open the cmake_install.cmake files, you will see that the CMAKE_INSTALL_CONFIG_NAME variable is empty on line 15.
>>
>> In CMake 3.0.2 the variable is set with the value "Release".
>>
>> Best Regards
>>
>>
>>> Am 20.01.2015 um 18:40 schrieb Robert Maynard <robert.maynard at kitware.com>:
>>>
>>> Hi,
>>>
>>> I haven't seen this issue but if you have a self-contained and reduced
>>> (preferably plain CMake ) test case, I would be happy to run it and
>>> verify if this is a regression.
>>>
>>>> On Tue, Jan 20, 2015 at 2:37 AM, NoRulez <norulez at me.com> wrote:
>>>> No one?
>>>>
>>>> Has something changed between 3.0.2 to 3.1.0 which prevents cpack to copy the generated *.exe file to the _CPack_Packages directory? Or did i need an additional variable to be set in 3.1.0?
>>>>
>>>> Thanks in advance
>>>>
>>>> Best Regards
>>>>
>>>>
>>>>> Am 16.01.2015 um 12:09 schrieb NoRulez <norulez at me.com>:
>>>>>
>>>>> If I switch back to 3.0.2 everything is working like a charm
>>>>>
>>>>> Best Regards
>>>>>
>>>>>> Am 15.01.2015 um 17:49 schrieb NoRulez <norulez at me.com>:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> we have only upgraded to the last release 3.1.0 from 3.0.2 and get the following when cpack is executed in a CTestScript:
>>>>>>
>>>>>> error: fixup_bundle: not a valid bundle
>>>>>>
>>>>>> The files are ceated, but they are not copied to the _CPack_Packages folder
>>>>>>
>>>>>> Then I found out that the variable "CMAKE_INSTALL_CONFIG_NAME" is empty in the cmake_install.cmake files
>>>>>>
>>>>>> Any hints?
>>>>>>
>>>>>> Best Regards
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Powered by www.kitware.com
>>>>>>
>>>>>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>>>>>
>>>>>> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>>>>>>
>>>>>> CMake Support: http://cmake.org/cmake/help/support.html
>>>>>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>>>>>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>>>>>
>>>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>>>
>>>>>> Follow this link to subscribe/unsubscribe:
>>>>>> http://public.kitware.com/mailman/listinfo/cmake
>>>>> --
>>>>>
>>>>> Powered by www.kitware.com
>>>>>
>>>>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>>>>
>>>>> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>>>>>
>>>>> CMake Support: http://cmake.org/cmake/help/support.html
>>>>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>>>>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>>>>
>>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>>
>>>>> Follow this link to subscribe/unsubscribe:
>>>>> http://public.kitware.com/mailman/listinfo/cmake
>>>> --
>>>>
>>>> Powered by www.kitware.com
>>>>
>>>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>>>
>>>> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>>>>
>>>> CMake Support: http://cmake.org/cmake/help/support.html
>>>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>>>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>>>
>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/cmake
>> --
>>
>> Powered by www.kitware.com
>>
>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>>
>> CMake Support: http://cmake.org/cmake/help/support.html
>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/cmake
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake