[cmake-developers] [PATCH] Fix a few issues in FindHDF5 module

Brad King brad.king at kitware.com
Mon Aug 31 14:53:31 EDT 2015


On 08/31/2015 04:47 AM, Paul Romano wrote:
> I'd like to offer the attached patch for consideration

Thanks for working on these changes.

Please split each independent fix out into its own commit with
corresponding commit message explaining the change.

For the HDF5_PREFER_PARALLEL implementation, please re-use
the existing find_program calls but simply prepare a variable
ahead of time that lists the preferred order of names.  OTOH,
there is another approach to solve this.  The find_library
command has a NAMES_PER_DIR option that says to consider all
the given names in each directory before moving on to the next
directory.  If find_program had this too then one would be able
to choose a preference simply by having one come first in PATH.

-Brad



More information about the cmake-developers mailing list