[cmake-developers] [PATCH] Add a test for checking that the CPack module produces correct config files

Domen Vrankar domen.vrankar at gmail.com
Mon Aug 31 02:27:58 EDT 2015


> My motivation is this. I want to submit a few improvements to the way CPack
> writes config files, starting with that cpack_set_if_not_set change I
> mentioned a while back. This functionality is generator-independent (and
> basically unrelated to actual package generation), so I thought
> RunCMake.CPack was not the appropriate place to test it.

Yes you're right, RunCMake.CPack is meant for specific generators and
adding target 'none' or something similar would just make a mess.

> Since there doesn't seem to be a test suite specifically for config file
> writing, I thought I'd create one in a separate patch so that my later
> patches don't have as much boilerplate in them. The Simple test is just
> there to ensure I don't break the simple case while changing the more
> complex ones. Well, and it would be silly to submit a test suite with no
> tests in it.

I've added your test:
http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=674dc0b

Thanks,
Domen


More information about the cmake-developers mailing list