[cmake-developers] [PATCH] Imported OpenSSL

Konstantin Podsvirov konstantin at podsvirov.pro
Thu Aug 13 09:43:57 EDT 2015


Hello, Brad!

Again OpenSSL :-)

Topic branch (for reference)
http://git.podsvirov.pro/?p=kitware/cmake.git;a=shortlog;h=refs/heads/topic-imported-openssl

11.08.2015, 22:35, "Gregor Jasny" <gjasny at googlemail.com>:
> On 07/08/15 13:22, Konstantin Podsvirov wrote:
>> Hi developers and experts OpenSSL!
>>
>> I added a little boring and dense of code at the end FindOpenSSL.cmake module.
>> I just want to have imported the OpenSSL library for creating relocatable packages.
>>
>> I created a theme topic-imported-openssl on my server:
>> http://git.podsvirov.pro/?p=kitware/cmake.git;a=shortlog;h=refs/heads/topic-imported-openssl
>>
>> Now I have a single commit:
>> http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=b47293f212f270844dcd32e36cff2a8668080c46
>
> Two comments:
>> + INTERFACE_LINK_LIBRARIES OpenSSL::Crypto
>> + IMPORTED_LINK_INTERFACE_LIBRARIES OpenSSL::Crypto
>> + IMPORTED_LINK_INTERFACE_LIBRARIES_DEBUG OpenSSL::Crypto
>> + IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE OpenSSL::Crypto)
>
> IMHO the last three are superfluous. Also documentation states that
> IMPORTED_LINK_INTERFACE_LIBRARIES is deprecated.

Fixed:
http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=273183ff776e153410c04e2f564addfde62558a4

>> +# This module defines :prop_tgt:`IMPORTED` target `OpenSSL::SSL` and
>> +# `OpenSSL::Crypto`, if OPENSSL_SSL_LIBRARY and OPENSSL_CRYPTO_LIBRARY
>> +# has been found.
>
> ^^^
> have been

Fixed:
http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=2d695eba249eec20eafdc32873d150342f3ee926

> Thanks,
> Gregor

11.08.2015, 16:05, "Brad King" <brad.king at kitware.com>:
> On 08/07/2015 07:22 AM, Konstantin Podsvirov wrote:
>> I created a theme topic-imported-openssl on my server:
>> http://git.podsvirov.pro/?p=kitware/cmake.git;a=shortlog;h=refs/heads/topic-imported-openssl
>
> Thanks. Please revise the patch to add the IMPORTED_CONFIGURATIONS
> target property listing the configurations that exist. See the
> FindQt4, FindGSL, and FindGTK2 modules for examples.

Fixed:
http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=33c2ea3908cdb196dfc88266480497106ea28649

> Also please add a test. Grep in the Tests directory for "FindGSL"
> to see the structure of how we're testing find modules.

Fixed:
http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=a50228237f9dfffd856362fd68b61260520c0848
http://git.podsvirov.pro/?p=kitware/cmake.git;a=commit;h=56ceb2dc3414246665510802e938ad9f1c60ed46

I checked the test c for Windows options:
-DCMake_TEST_FindOpenSSL=ON -DOPENSSL_ROOT_DIR=<path>

For me it works.

> Thanks,
> -Brad

Brad, please consider the changes and the possibility of their application.

--
Regards,
Konstantin Podsvirov


More information about the cmake-developers mailing list