[cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

[Brad King]

On 08/11/2015 05:00 PM, Ray Donnelly wrote:
> You can see our patch to add MSYS2 support here:
> https://github.com/Alexpux/MSYS2-packages/blob/master/cmake/cmake-3.2.3-msys.patch
> .. #if defined(__MSYS__) is used and we just set CMAKE_SYSTEM_NAME to
> MSYS, not MSYS2.

Good start.

> If we risk breaking MSYS then we can go for MSYS2 I guess.

I don't think that will be a problem because MSYS/mingw.org builds
use CMAKE_SYSTEM_NAME set to "Windows".

Like Cygwin, the MSYS2-native CMake should not be used for Windows
builds and the Windows-native CMake should not be used for MSYS2-native
builds.

> Alexey Pavlov did all of the work on our msys2/cmake package and
> he's on holiday this month.

I guess it's best to wait for Alexey.  Please raise this again with
him in Cc when he returns.

Thanks,
-Brad