[cmake-developers] [PATCH] CMakeDetermineSystem.cmake distinguishes-MSYS-MINGW32 (was Re: Distinguishing MSYS2

[Greg Jung]

Do note that I am an "observer" or "reporter" and not responsible for the
posix-version cmake in msys2.  Ray Donnelly is much closer to that than I
am.
What I can do, though, is bring in the modules (.cmake files) and make sure
the changes (already) effected there can co-exist with a normal MSYS (using
mingw) module collection.  Currently, MSYS is almost exactly parallel to
CYGWIN and this would need to be either (MSYS AND CMAKE_HOST_UNIX) or (MSYS
AND NOT MINGW).  Probably the latter.

Regards,
Greg

On Tue, Aug 11, 2015 at 6:18 AM, Brad King <brad.king at kitware.com> wrote:

> On 08/10/2015 04:07 PM, Greg Jung wrote:
> > There is an msys2-specific cmake version already built along those lines,
> > with several patches in the modules section to parallel the CYGWIN cases,
> > in the msys2 distribution.  It does not have a "MSYS Makefiles" generator
> > option but uses "Unix generator"  as you anticipate.
>
> In order to get CMAKE_HOST_UNIX set properly for CMakeDetermineSystem
> shouldn't we upstream your changes for a msys2-specific CMake?  I presume
> it does a "#if defined(__MSYS__)" somewhere near where we already do
> "#if defined(__CYGWIN__)".
>
> Thanks,
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20150811/f0e88d68/attachment.html>