[cmake-developers] A CMAKE_EMULATOR variable
Matt McCormick
matt.mccormick at kitware.com
Sun Apr 5 23:07:09 EDT 2015
> In each place that you ExpandListArgument to get the emulator
> command and arguments and write them out before an executable
> name, you need to be sure to make the proper call to escape
> each argument. In each case the code just below your hunk
> does this for the test arguments.
Good catch. Fixed.
> The Tests/RunCMake/pseudo_emulator.cxx tool must be able to
> compile with any of the compilers we test, not just those that
> host the build of CMake. It will be more portable to use a
> .c file with <stdio.h> and printf. Also, please make it print
> out each argument in quotes so one could match expected output
> in the future.
Done. If I recall correctly, there are not other tests that try to
verify try_run output, so I did not open that can of worms.
>> +RunCMake_TEST:STRING=AddTest
>
> Why is this needed in InitialCache.cmake?
Seems like leftover cruft. Removed.
Thanks for the review. The new branch has been force pushed to the
stage as "emulator-property".
Thanks,
Matt
More information about the cmake-developers
mailing list