[cmake-developers] [PATCH] FindIce: Remove unneeded search path modification

Brad King brad.king at kitware.com
Tue Sep 9 11:48:53 EDT 2014


On 09/09/2014 11:35 AM, Roger Leigh wrote:
> I have attached a minor fix to the FindIce module added a couple of
> weeks back.

Applied, thanks:

 FindIce: Remove unneeded search path modification
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d5047ca1

While reviewing I noticed that there are some message(STATUS) calls
not protected by if(Ice_DEBUG) or checks of Ice_FIND_QUIETLY.  The
latter is needed to honor the QUIET option of find_package.  Please
revise in a follow-up patch.

Thanks,
-Brad




More information about the cmake-developers mailing list