[cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case

Bach, Pascal pascal.bach at siemens.com
Tue Sep 9 10:19:47 EDT 2014


> Those are all for the Makefile and Ninja generators, as are
> CMAKE_CREATE_WIN32_EXE and CMAKE_CREATE_CONSOLE_EXE. For VS
> generators the knowledge has always been hard-coded, with a
> special case for Windows CE:
> 
> 
> http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalVisual
> Studio7Generator.cxx;hb=v3.0.1#l1122
> 
> The cmVisualStudio10TargetGenerator could be taught this
> similarly.

Wouldn't it make sense to use the same variables in the VS10+ Generator too?
It seems redundant to have the same information again. What's the reason it is hardcoded?

Pascal



More information about the cmake-developers mailing list