[cmake-developers] ExternalProject CMAKE_ARGS and CMAKE_CACHE_ARGS arguments

Brad King brad.king at kitware.com
Thu Oct 30 11:45:40 EDT 2014


On 10/30/2014 10:21 AM, Daniele E. Domenichelli wrote:
> I updated the topic and modified one of the tests in
> ExternalProjectLocal to use the new CMAKE_CACHE_DEFAULT_ARGS argument.

Thanks.

> Unfortunately this triggered a hidden bug in the external projects, so I
> fixed it with an extra commit, see:
> 
>  http://www.cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=2c3b9a91

Instead of allowing a possible fault and then needing 'isnan',
please fix the examples to check for a value >= 0 before calling
sqrt.

Then please merge the topic to 'next' for testing when ready.

Thanks,
-Brad



More information about the cmake-developers mailing list