[cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

[Rolf Eike Beer]

Am Montag, 27. Oktober 2014, 10:55:50 schrieb Brad King:
> On 10/27/2014 10:41 AM, Rolf Eike Beer wrote:
> >> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_PRE"  OR
> >> "${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_POST")
> > 
> > This should really be using STREQUAL and not using dereferences on the
> > left hand side.
> 
> Thanks.  Actually I mentioned that in my first review in this thread
> but forgot to check that it had been resolved in updated patches.
> 
> It doesn't matter though because the second commit replaces that
> line with different logic anyway.

Why not use that logic from the beginning then?

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141027/30618843/attachment.sig>