[cmake-developers] Recent GetPrerequisites changes

[David Cole]

Eike,

The changes you made in this commit:

http://www.cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ec36e1c2afe7c8258588dd51a9fe75b7fb523206

appear to have introduced a change in behavior such that the test is
running recursive dependency checks instead of just direct dependency
checks.

Evidence:
11/18: test passed in under 3 seconds:
http://open.cdash.org/testDetails.php?test=294732956&build=3575799
updates: http://open.cdash.org/viewUpdate.php?buildid=3577230
11/19: test fails, times out after 10 minutes:
http://open.cdash.org/testDetails.php?test=294964093&build=3577230

I think the root of the problem is the tests for ARGV1, ARGV2, etc.
that you made are not equivalent to the previous code in the case of a
nested function call: (a function calling a function ... or deeper --
weird stuff happens if you call a function with fewer than its
declared arguments -- i.e. there is no ARGV2 variable within a
function called with only one argument, but there may be in the parent
scope if it's called from a function that does get called with 2 or
more args)

So.... some of the "needless" variable dereferencing you removed is
actually needed.

Would you mind reverting those commits, or modifying them such that
the new behavior is identical to the older behavior, please?


Thanks,
David C.