[cmake-developers] [PATCH] Preinstall requirements support for CPack RPM generator

[Evgeny Kalishenko]

To my mind issue http://public.kitware.com/Bug/view.php?id=14769 can be
resolved after the patch

2014-10-27 21:34 GMT+04:00 Rolf Eike Beer <eike at sf-mail.de>:

> Am Montag, 27. Oktober 2014, 10:55:50 schrieb Brad King:
> > On 10/27/2014 10:41 AM, Rolf Eike Beer wrote:
> > >> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_PRE"  OR
> > >> "${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_POST")
> > >
> > > This should really be using STREQUAL and not using dereferences on the
> > > left hand side.
> >
> > Thanks.  Actually I mentioned that in my first review in this thread
> > but forgot to check that it had been resolved in updated patches.
> >
> > It doesn't matter though because the second commit replaces that
> > line with different logic anyway.
>
> Why not use that logic from the beginning then?
>
> Eike




-- 
С уважением,
Евгений Калишенко
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141122/57c73c5d/attachment.html>