[cmake-developers] HP-UX Curses questions
Brad King
brad.king at kitware.com
Tue Nov 18 09:37:01 EST 2014
On 11/18/2014 6:16 AM, Ådne Hovda wrote:
> X/Open Curses does not specify the getmax[xy]() functions/macros, only
> getmaxyx()
Yes, it makes sense to use well-defined APIs. Thanks for explaining.
> I've pushed my changes to
> https://github.com/aadnehovda/CMake/tree/curses-hpux-fix and can create
> a pull request if you think this is okay.
No PR is needed. I've fetched from there. Please read CONTRIBUTING.rst,
though we can finish this one with your branch on Github.
This hunk:
> -#else
> -/* figure out which curses.h to include */
> -# if defined(CURSES_HAVE_NCURSES_H)
> -# include <ncurses.h>
> -# elif defined(CURSES_HAVE_NCURSES_NCURSES_H)
> -# include <ncurses/ncurses.h>
> -# elif defined(CURSES_HAVE_NCURSES_CURSES_H)
> -# include <ncurses/curses.h>
> -# else
> -# include <curses.h>
> -# endif
removes a bunch of logic when __hpux is not defined. I think that
is still needed on all platforms to include the proper curses
headers. That should be able to subsume the hpux case now.
Please revise or explain.
Thanks,
-Brad
More information about the cmake-developers
mailing list