[cmake-developers] New command 'file(LOCK_DIRECTORY ...)'

[Brad King]

On 11/14/2014 12:31 PM, Ruslan Baratov wrote:
> ConvertToWindowsExtendedPath fix + tests

Thanks.  I started testing on Linux so far.  A few more comments:

- Please add more test cases covering all the file(LOCK)
  argument processing error messages.

- Please squash in the attached patch to your commit that
  adds the file(LOCK) command to CMake.  We should not need
  to build it during bootstrap.

- Instead of ::sleep you can use cmSystemTools::Delay()

- We need to test whether failing to lock after a timeout
  actually works.  I tried adding a line to
  Tests/RunCMake/file/LOCK.cmake:

   file(LOCK "${lfile}" TIMEOUT 3)

  at the end of the file, duplicating the one before it.
  I expected to see a 3 second delay followed by a lock
  failure.  Instead it fails immediately.  Is that expected?

Thanks,
-Brad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-file-LOCK-Drop-this-API-during-CMake-bootstrap-build.patch
Type: text/x-diff
Size: 4306 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141114/18a7d07e/attachment.patch>