[cmake-developers] string SUBSTRING TRUNCATE mode

[Brad King]

On 11/13/2014 12:48 PM, Rolf Eike Beer wrote:
> This should be a good addition, no?
> 
> diff --git a/Modules/CPackRPM.cmake b/Modules/CPackRPM.cmake
> index 56d9b66..66717ef 100644
> --- a/Modules/CPackRPM.cmake
> +++ b/Modules/CPackRPM.cmake
> @@ -683,9 +683,7 @@ foreach(_RPM_SPEC_HEADER URL REQUIRES SUGGESTS PROVIDES OBSOLETES PREFIX CONFLIC
>      # Transform NAME --> Name e.g. PROVIDES --> Provides
>      # The Upper-case first letter and lowercase tail is the
>      # appropriate value required in the final RPM spec file.
> -    string(LENGTH ${_RPM_SPEC_HEADER} _PACKAGE_HEADER_STRLENGTH)
> -    math(EXPR _PACKAGE_HEADER_STRLENGTH "${_PACKAGE_HEADER_STRLENGTH} - 1")
> -    string(SUBSTRING ${_RPM_SPEC_HEADER} 1 ${_PACKAGE_HEADER_STRLENGTH} _PACKAGE_HEADER_TAIL)
> +    string(SUBSTRING ${_RPM_SPEC_HEADER} 1 -1 _PACKAGE_HEADER_TAIL)
>      string(TOLOWER "${_PACKAGE_HEADER_TAIL}" _PACKAGE_HEADER_TAIL)
>      string(SUBSTRING ${_RPM_SPEC_HEADER} 0 1 _PACKAGE_HEADER_NAME)
>      set(_PACKAGE_HEADER_NAME "${_PACKAGE_HEADER_NAME}${_PACKAGE_HEADER_TAIL}")

Yes, once the main change is in 'master' please add a topic to
update call sites like this.

Thanks,
-Brad