[cmake-developers] string SUBSTRING TRUNCATE mode

Domen Vrankar domen.vrankar at gmail.com
Wed Nov 12 18:08:58 EST 2014


> You could check the value of the CMAKE_MINIMUM_REQUIRED_VERSION
> variable to decide whether to make it an error.  Extend the error
> message to mention that it could be fixed by requiring a new
> enough version of CMake.  OTOH, there have been many times in the
> past where we've converted an error case to a non-error case
> without such a check.  Projects should test themselves with the
> oldest CMake they support anyway.  I have no strong feeling on
> this requirement.

I have decided against the checking for back compatibility as it would
only make writing of modules that come with CMake harder.

Attached is the final patch. I have changed the already existing tests
and added a note regarding the change in documentation. If this patch
will not make it into CMake 3.1 the note in documentation should be
changed before applying the patch.

Please review the patch and if there are no changes required add it to
the repository.

Thanks,
Domen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-string-SUBSTRING-length-exceeding-end-index.patch
Type: text/x-diff
Size: 4159 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141113/a8d1b4c1/attachment.patch>


More information about the cmake-developers mailing list