[cmake-developers] [CPack] [CPackRPM]patch for bug 15209 - handling of symbolic links

[Domen Vrankar]

2014-11-10 17:44 GMT+01:00 Brad King <brad.king at kitware.com>:
> On 11/08/2014 04:17 PM, Domen Vrankar wrote:
>> Patch add support for symlink handling in RPM packages.
>> Symlinks to directories and files are correctly recognized as such so
>> directory symlinks are no longer prefixed with %dir.
>> In case of relocatable RPM packages the patch also tries to make
>> symlink as relocatable as possible by making a relative path symlink
>> if needed.
>
> Thanks.  Please also look at extending the test suite with a
> case for this.  There are several CPack RPM tests already.

I'll add the tests to the patch.

> Also, since the rpm packaging tools are posix-specific anyway,
> perhaps it will be easier to maintain this transformation as a
> standard shell script.  I don't feel strongly about this, but
> we have the option to do it that way.  The script could be
> launched with execute_process.

I've just noticed that I can remove a large part of the patch
(attached) and replace it with a single file command. I'll try to
shorten the patch even further and than if it will still be too long
and complex I'll consider replacing it with a shell script.

Domen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CPackRPM-handling-of-symbolic-links.patch
Type: text/x-diff
Size: 10739 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141110/43fea0e3/attachment.patch>