[cmake-developers] [Review Request][3.1-rc1 regression] topic fix_link-line-dedup_regression

Brad King brad.king at kitware.com
Mon Nov 10 10:49:18 EST 2014


On 11/10/2014 10:46 AM, Daniele E. Domenichelli wrote:
>> - See if it can be integrated into the Tests/Dependency test,
>>   perhaps as a new Case5 directory.
> 
> Done, see:
> 
>  Convert the test to use C only and move it into Tests/Dependency/Case5
>  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c875db31

Thanks.  Please rename the 'foo' and 'bar' libs to 'case5Foo' and
'case5Bar' to avoid conflict with other cases in the future.

> It should probably be squashed to a4716b6b...

I will squash it all before merging to master or release.

Thanks,
-Brad



More information about the cmake-developers mailing list