[cmake-developers] Please review patch for 'continue' keyword

Brad King brad.king at kitware.com
Mon Nov 3 09:27:49 EST 2014


On 10/31/2014 04:00 PM, Gregor Jasny wrote:
> http://www.cmake.org/Bug/view.php?id=14013
> 
> I re-applied the patch to master, fixed some bit-rot and formatted it
> via git format-patch (also attached). Could you please take a look? It
> would be great if the 'continue' keyword support would be part of CMake
> 3.2.

Thanks for working on this.  The patch looks like a good start.
In order to be integrated a bit more work is needed:

- Tests covering the command are needed.  They can be added as
  a new Tests/RunCMake/continue test.

- It needs to be an error to call continue() outside of a suitable
  context.

Thanks,
-Brad



More information about the cmake-developers mailing list