[cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

Brad King brad.king at kitware.com
Thu Mar 27 13:50:53 EDT 2014


On 03/27/2014 12:24 PM, Daniele E. Domenichelli wrote:
> +  if(";${ARGN};" MATCHES ";EXCLUDE_FROM_ALL;([^;]*);")
> +    set(exclude_from_all ${CMAKE_MATCH_1})
> +  endif()
> +  if(NOT exclude_from_all)
> +    set(all ALL)
> +  endif()

We need to be robust against variables set in outer scopes:

 set(all ALL)
 if(";${ARGN};" MATCHES ";EXCLUDE_FROM_ALL;([^;]*);")
   if(CMAKE_MATCH_1)
     set(all "")
   endif()
 endif()

-Brad




More information about the cmake-developers mailing list