[cmake-developers] Review Request: Topic ExternalProject_exclude-from-all

[Brad King]

On 03/27/2014 11:23 AM, Daniele E. Domenichelli wrote:
> Is it ok to merge it to next?

Yes, but let's do only one change to ExternalProject per day so
we can see how the tests do.

> +  # _ep_parse_arguments requires that the target already exists,
> +  # therefore must be called after add_custom_command
> +  list(FIND ARGN EXCLUDE_FROM_ALL exclude_from_all_index)

Typo:

 s/add_custom_command/add_custom_target/

A simpler way to look for the argument:

 if(";${ARGN};" MATCHES ";EXCLUDE_FROM_ALL;([^;]*);")
   # ... test CMAKE_MATCH_1
 endif()

Thanks,
-Brad