[cmake-developers] [PATCH] Correct platform related variables for Open Watcom compilers

Jiri Malak malak.jiri at gmail.com
Fri Mar 14 09:57:45 EDT 2014


>>>> I enclosed patch to fix COMPILER_VERSION variable value
>>>> for Open Watcom compilers to be real version, not internal number.
>>> [snip]
>>>> +  /* __WATCOMC__ = VVRR + 1100 Open Watcom */
>>>
>>> What do you think about changing the compiler id to "OpenWatcom"?
>>>
>> It can be changed, I am using Watcom as simple word.
>
> My concern is that we've reported CMAKE_C_COMPILER_ID as "Watcom"
> along with CMAKE_C_COMPILER_VERSION holding numbers like 12.x for
> a long time.  Projects may have logic that switches off these version
> values when they see the id is "Watcom".
>
> By changing to "OpenWatcom" we get a more accurate description of
> the compiler name and can restart the version sequence at 1.x.
> Please fold this into the patch.
>
> Also please split the patch into two commits.  The first should
> do the compiler id and version change, and the second should
> do the platform and architecture fix.
>
OK. I introduce OpenWatcom as new compiler ID.

Jiri






More information about the cmake-developers mailing list