[cmake-developers] [PATCH] Wrap ARGV1 and ARGV2 in quotes to avoid errors when they are empty

[Aurélien Gâteau]

Aurélien Gâteau wrote:

> Stephen Kelly wrote:
> 
>> Aurélien Gâteau wrote:
>> 
>>> Wrap ARGV1 and ARGV2 in quotes to avoid errors when they are empty
>> 
>> The user code has an error and your patch silently hides it.
>> 
>> How is that an improvement?
> 
> Thank you for your kind words.
> 
> Here is an updated patch.

Actually previous patch was still wrong, since some versions may evaluate to 
0. Testing with STREQUAL is safer I think.

Aurélien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Give-an-helpful-message-if-VERSION-is-empty-instead-.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140313/3faac3e6/attachment-0002.bin>