[cmake-developers] [Review request] Topic FindPkgConfig_Extend-PKG_CONFIG_PATH

[Brad King]

On 03/10/2014 10:38 AM, Brad King wrote:
> Thanks.  Now the docs look good too.  Please rebase on master
> and merge to 'next' for testing.

Please add test cases for the FindPkgConfig interface and argument
parsing errors.  The test can just fake the location of pkg-config
with a dummy if necessary.

Also the hunks:

+        if(UNIX)
+          string(REPLACE "\\:" ";" _path "${_path}")
+        endif()

should not be necessary because TO_CMAKE_PATH already does that.
It looks like TO_NATIVE_PATH does not do the reveres though so that
explicit replacement is still needed.

Thanks,
-Brad