[cmake-developers] [Review request] Topic FindPkgConfig_Extend-PKG_CONFIG_PATH

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Thu Mar 6 20:15:07 EST 2014


>>   if (debian) add lib/<arch>
>>   elseif (64 bit or unknown) add lib64
>>   add lib
>
> That looks good except for FIND_LIBRARY_USE_LIB64_PATHS.

Fixed. Now the logic is

  if (debian) add lib/<arch>
  elseif (FIND_LIBRARY_USE_LIB64_PATHS) add lib64
  add lib



> The text defining the command needs to be indented to be part of
> the explicit markup block.
> [...]
> command signatures should be plain literal blocks
> and not "cmake" code-blocks.

Done and done.



> I pushed a "doc-osx-path-variables" topic to the stage to document
> these variables.  You may rebase on that to reference them.

Rebased.



Cheers,
 Daniele



More information about the cmake-developers mailing list