[cmake-developers] [Review request] Topic FeatureSummary_combine_WHAT_values

Brad King brad.king at kitware.com
Mon Mar 3 11:21:40 EST 2014


On 02/28/2014 12:17 PM, Daniele E. Domenichelli wrote:
> Please review the topic FeatureSummary_combine_WHAT_values.
> 
> This patch allows to combine and reorder values for the "WHAT" option in
> FeatureSummary.

In principle the change looks good to me but I'm not familiar with this
module as a developer or user so I cannot comment in more detail.

Please add a Tests/RunCMake/FeatureSummary test to cover at least the
new error messages.

Thanks,
-Brad



More information about the cmake-developers mailing list