[cmake-developers] [Patch] Remove hard coded version of RTDLL for Open Watcom

Brad King brad.king at kitware.com
Mon Mar 3 09:55:03 EST 2014


On 02/28/2014 09:47 PM, Jiri Malak wrote:
> remove hardcoded version number for RTDLL.
> It is derived from compiler version now

Good, thanks.  Just a couple comments:

The patch seems to make some unrelated whitespace changes.  Please
factor those out into a separate commit.

The WATCOM<NN> variables are left for compatibility with projects
that expected them to be defined prior to the general availability
of CMAKE_(C|CXX)_COMPILER_VERSION and should not be removed.  We
don't have to add any for newer versions of Open Watcom though,
and can remove uses of them within other CMake-provided modules
as you did from InstallRequiredSystemLibraries.

We need to decide whether WATCOM_RTDLL_VERSION is to be a public
variable or not.  If not then it should be named with a "_" prefix
or dropped completely and the logic moved to
InstallRequiredSystemLibraries.  If so then we should add docs
for it.  My preference is to keep it private so it can be refactored
later for some currently unforeseen reason.  Applications that need
the value can always check CMAKE_(C|CXX)_COMPILER_VERSION themselves.

Thanks,
-Brad



More information about the cmake-developers mailing list