[cmake-developers] [PATCH 1/3] Ninja: Consider only custom commands deps as side-effects (#14972)

[Brad King]

On 06/27/2014 04:13 PM, Adam Strzelecki wrote:
> Previously all explicit dependencies inside build folder were considered as
> possible build command side-effects and phony rules were produced for them in
> case they don't exist yet starting build. This however incorrect since regular
> compile inputs need to exist otherwise cmake will fail. Moreover the exception
> for sources having GENERATED property that can be missing is already handled by
> WriteAssumedSourceDependencies.

Thanks!  I've applied this series with minor tweaks to coding
style and the commit messages:

 Ninja: Consider only custom commands deps as side-effects (#14972)
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a33cf6d0

 Ninja: Don't limit custom cmd side-effects to build folder (#14972)
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7243c951

 Ninja: Skip generating empty phony rules
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=93371ed5

-Brad