[cmake-developers] [PATCH 5/5] FindBoost.cmake: Add Boost::boost and Boost::<C> targets and documentation

Philipp Moeller bootsarehax at gmail.com
Tue Jun 24 09:48:48 EDT 2014


Brad King <brad.king at kitware.com> writes:

> On 06/20/2014 01:09 PM, Philipp Möller wrote:
>> +#   Boost::boost                  - interface target containing the include
>> +#                                   directory
>
> Nice.
>
>> +      if(Boost_USE_STATIC_LIBS)
>> +        add_library(Boost::${COMPONENT} STATIC IMPORTED)
>> +      else()
>> +        add_library(Boost::${COMPONENT} SHARED IMPORTED)
>> +      endif()
>
> IIRC, Boost_USE_STATIC_LIBS asks for static libraries, but when it is
> OFF we might still get static libraries.  Therefore the else() case
> still needs to mark it as UNKNOWN.

You are right. Attached is a fixed patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: FindBoost-targets.patch
Type: text/x-diff
Size: 4179 bytes
Desc: Fixup FindBoost patch
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20140624/baad3b89/attachment-0002.patch>


More information about the cmake-developers mailing list