[cmake-developers] [PATCH 2/2] Ninja: Fix failing CMakeLib.testRST test

[Peter Kümmel]

On 06.06.2014 16:53, Sam Spilsbury wrote:
> On Fri, Jun 6, 2014 at 10:49 PM, Brad King <brad.king at kitware.com> wrote:
>> On 06/06/2014 10:12 AM, Sam Spilsbury wrote:
>>> Ninja was passing a relative path to the compiler which causes
>>> __FILE__ to use that same relative path. This was causing the test to
>>> fail, because Ninja is not a recursive generator and so __FILE__
>>> differed between generators.
>>>
>>> For the sake of consistency, an absolute path should always be passed
>>> to the compiler on each generator, so that __FILE__ is always
>>> consistent.
>>
>> This is a larger debate for those that develop and use the Ninja
>> generator.  For now let's just fix the test to not depend on a
>> full path to __FILE__:
>
> Are there any threads where I can read up on background information
> for this? Having consistency seems like a no-brainer to me, so perhaps
> I missed something?

This is very hairy, see here where we once already tried this:

http://public.kitware.com/Bug/view.php?id=13894

>
> Briefly reading[1], it seems like the Chromium developers are
> preferring consistency between generator backends.
>
> Sam.
>
> [1] https://code.google.com/p/chromium/issues/detail?id=326030
>
>>
>>   Tests: Fix CMakeLib.testRST for relative __FILE__
>>   http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=218699eb
>>
>> -Brad
>>
>> --
>>
>> Powered by www.kitware.com
>>
>> Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Kitware offers various services to support the CMake community. For more information on each offering, please visit:
>>
>> CMake Support: http://cmake.org/cmake/help/support.html
>> CMake Consulting: http://cmake.org/cmake/help/consulting.html
>> CMake Training Courses: http://cmake.org/cmake/help/training.html
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
>
>
>