[cmake-developers] LZMA support
David Cole
dlrdave at aol.com
Wed Jul 23 11:23:33 EDT 2014
>> Thanks. Actually I think adding "xz" is incorrect anyway. We
>> support compressed tarballs, not arbitrary compressed files.
>> Therefore the list should be
>>
>> 7z|bz2|tar\\.gz|tar\\.xz|tgz|txz|zip
>>
>> correct?
>
> Well, then it should be tar.bz2, too. And since this is a regex
anyway:
>
> 7z|tar\\.bz2|tar\\.[gx]z|t[xg]z|zip
Yes, correct.
I still like the original "list all the extensions separately and
explicitly" technique rather than "'simplifying' the regex" -- because
the first one is an "easier to parse as a human being" regex. Also,
it's "more greppable" if somebody is looking for .gz or .xz or tgz or
txz.
D
More information about the cmake-developers
mailing list