[cmake-developers] [Review Request] Topic CMakePackageConfigHelpers_build_tree

Daniele E. Domenichelli daniele.domenichelli at gmail.com
Mon Jul 21 11:38:31 EDT 2014


On 21/07/14 16:17, Brad King wrote:
> On 07/21/2014 04:54 AM, Daniele E. Domenichelli wrote:
>> I indented the whole command block, can you please have a look if that's
>> what you meant? Or is it just the "brief description" of the command
>> that should be indented?
> 
> I think just the signature summary is enough.  Section headers
> can be used if we need a higher-level organization.

Done.


> Also please review the style guidelines:
> 
>  http://www.cmake.org/cmake/help/git-master/manual/cmake-developer.7.html#style
> 
> In particular, self-references should be plain inline literals:

Done.



Cheers,
 Daniele




More information about the cmake-developers mailing list