[cmake-developers] [Review Request] Topic CMakePackageConfigHelpers_build_tree

Brad King brad.king at kitware.com
Thu Jul 17 10:33:28 EDT 2014


On 07/16/2014 11:55 AM, Daniele E. Domenichelli wrote:
> Please review the topic CMakePackageConfigHelpers_build_tree.
> 
> This patch adds an option BUILD_TREE to configure_package_config_file.

The changes look good to me, though I'd appreciate feedback from
others who have worked on this module before.

In the documentation formatting commit, I see blocks like:

> +# .. command:: configure_package_config_file
> +#
> +# Create a config file for a project::

The definition of the command should be in an indented block so
that reST knows it is part of the explicit markup block.

Thanks,
-Brad




More information about the cmake-developers mailing list