[cmake-developers] CMAKE_VISIBILITY_INLINES_HIDDEN incorrectly applied to non C++ sources?

Stephen Kelly steveire at gmail.com
Fri Jan 31 11:30:15 EST 2014


Nils Gladitz wrote:

> On 01/31/2014 02:27 PM, Stephen Kelly wrote:
>> help? If so, can you see about adding a unit test and merging to next?
> 
> I merged "fix-visibility-inlines-hidden" to "next" with a new test
> "VisibilityInlinesHidden".
> 
> The test is currently only enabled for gcc on linux.
> It might work for other compilers/platforms as well but it should at
> least cover the CMake aspect as-is.
> 
> It verifies that there are no warnings (from incorrectly applying
> -fvisibility-inlines-hidden to C sources) and uses "nm" to check if
> symbols actually get hidden in C++ sources.

Looks good to me, thanks!

Steve.





More information about the cmake-developers mailing list