[cmake-developers] CMAKE_VISIBILITY_INLINES_HIDDEN incorrectly applied to non C++ sources?

Nils Gladitz nilsgladitz at gmail.com
Fri Jan 31 08:53:39 EST 2014


On 01/31/2014 02:27 PM, Stephen Kelly wrote:
> Does a patch like
>
>     AddVisibilityCompileOption(flags, target, this, lang);
> -  AddInlineVisibilityCompileOption(flags, target, this);
> +  if (strcmp(lang, "CXX"))
> +    {
> +    AddInlineVisibilityCompileOption(flags, target, this);
> +    }

"if (strcmp(lang, "CXX") == 0)" should work.

>
> help? If so, can you see about adding a unit test and merging to next?

I've got no idea how to test for this properly (yet) but I'll look into it.

Thanks!

Nils



More information about the cmake-developers mailing list