[cmake-developers] Request to review topic "codelite-ide-generator"

[Brad King]

On 01/09/2014 01:43 PM, Eran Ifrah wrote:
> Thanks!
> On Thu, Jan 9, 2014 at 8:42 PM, Nils Gladitz <nilsgladitz at gmail.com <mailto:nilsgladitz at gmail.com>> wrote:
>     Direct link to the CMake Dashboard: http://open.cdash.org/index.php?project=CMake

FYI, there are a few problems with the topic on the continuous builds.
Among them are:

 http://open.cdash.org/viewBuildError.php?type=1&buildid=3170636
 .../Help/generator/CodeLite.rst:: WARNING: document isn't included in any toctree

 http://open.cdash.org/viewBuildError.php?buildid=3170622
 Error E2193 ...\Source\cmExtraCodeLiteGenerator.cxx 217:
 Too few parameters in call to 'cmTarget::GetSourceFiles

The first is an omission of the new document from the toctree
in "Help/manual/cmake-generators.7.rst".

The second is a logical conflict with another change that
updated the signature of cmTarget::GetSourceFiles.  This is
just bad luck on the timing.  Logical conflicts like this have
been pretty rare so you're a "lucky" winner.

Please fetch the latest 'master', merge it into your topic,
get it compiling again locally, and then push and merge the
topic again to 'next'.  Alternatively revert the topic from
'next', rebase it on the latest master, and then push again
when you're ready.

Thanks,
-Brad