[cmake-developers] [New Module] FindOpenCL, FindHg

[Brad King]

Hi Matthäus,

On 02/23/2014 03:34 AM, Rolf Eike Beer wrote:
> Looks better.

Thanks for your work on these.  I've split your branch into
separate topics for FindHg and FindOpenCL.  The FindHg changes
are now in master:

 FindHg: Search for TortoiseHg
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8993df6c

 FindHg: Add Hg_WC_INFO macro
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bcefbe73

I rebased and squashed the FindOpenCL module topic, with the
current draft here:

 Add FindOpenCL module
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=85f681f2

in a topic called 'add-FindOpenCL'.  However, the names of the
cache entries and result variables are not correct.  Please
read the "Find Modules" section of the cmake-developer(7)
manual:

 http://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/manual/cmake-developer.7.rst;hb=8619a453#l667

Basically the names

 OpenCL_LIBRARY
 OpenCL_INCLUDE_DIR

should be cache entries (through find_library, find_path, etc.)
that the user can set to the location of individual components
of the package.  They do not need to be in the documentation
but could be mentioned in a separate section about what cache
entries the module defines.

The names

  OpenCL_FOUND
  OpenCL_INCLUDE_DIRS
  OpenCL_LIBRARIES
  OpenCL_VERSION_STRING

should be normal variables, not cache entries, that report the
results for use by the calling application code.  These should
be documented.

Please fetch and checkout the topic from the stage and add
commits to revise the module accordingly.

Thanks,
-Brad