[cmake-developers] Request for review of topic "intel-visibility"
Brad King
brad.king at kitware.com
Fri Feb 7 10:24:05 EST 2014
On 02/07/2014 06:05 AM, Nils Gladitz wrote:
> CMAKE_<LANG>_COMPILE_OPTIONS_VISIBILITY is being set up for the Intel
> compiler in general but the -fvisibility option is not supported on
> Windows and will result in compiler warnings.
>
> I set up the "intel-visibility" topic which moves the option into the
> Windows and Darwin specific Platform files.
This looks correct to me and is a good bug fix. Please merge
to 'next' for testing.
BTW, the Darwin-icc.cmake file needs to be refactored into modern
Darwin-Intel-<lang>.cmake modules with a Darwin-Intel.cmake helper.
Do you have access to Intel C/C++ on OS X that you could use to try
this task?
Thanks,
-Brad
More information about the cmake-developers
mailing list