[cmake-developers] push of LinkOptionsCommand topic branch

Stephen Kelly steveire at gmail.com
Fri Feb 7 03:45:18 EST 2014


Steve Wilson wrote:

> 
> On Feb 6, 2014, at 3:56 PM, Stephen Kelly
> <steveire at gmail.com> wrote:
>> 
>> There are a few things I'd like to touch up a bit. How comfortable are
>> you with git? Would it cause problems for you if I force push your
>> branch, or would you know how to handle that? Do you have further local
>> changes?
> 
> 
> I’m a relative git newbie.   I can get around ok and am learning a bunch
> as I go.   The term ‘force push’ isn’t familiar though so I’m afraid
> you’ll have to explain (or I can look it up).   I do not have any more
> local changes.   I’ve switched to working on a different feature.

Ok, I'll not force push it yet but will do that later and tell you what you 
need to do in reaction then.

You still have extra dashes in the titles in the target property 
documentation.

Please also rebase to master. The documentation has been updated to add more 
relevant links, markup etc. Please follow the same patterns in all the new 
docs on your branch. 

Note also that your add_link_options doc copied some content from 
add_compile_commands without modifying it (re include directories).

Here's some guidance Brad gave me a while ago regarding writing commit 
messages with an imperative mood:

 http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6904

The new tests look good to me. Please use spaces not tabs in foo.cpp in the 
add_link_options test. You also add a foo.cpp in the target_link_options 
test, but it has no content. Is that deliberate, or should it be the same as 
the other?

In the 'cmLocalGenerator: Add AddLinkOptions method for LINK_FLAGS.' commit 
message, you mention that the differences regarding static and object 
libraries from the xcode generator are included. You don't say what impact 
that has on other generators though. 

Were the other generators buggy by not doing the same thing before? 

Or was the xcode generator special for needing this? 

If the xcode generator has a special need, then that snippet should stay in 
the xcode generator, right? 

Thanks,

Steve.





More information about the cmake-developers mailing list