[cmake-developers] [PATCH] Do not output transitive dependencies in feature_summary()
Stephen Kelly
steveire at gmail.com
Mon Feb 3 14:27:01 EST 2014
Hi,
It's generally preferable to write an email and attach the patch.
Alex Merry wrote:
> -# informative diagnostic message if the dependency could not be found.
> +# informative diagnostic message if the dependency could not be found,
> and +# marks the package as a TRANSITIVE_DEPENDENCY for
> +# :command:`feature_summary`.
feature_summary is not marked as a command for sphinx. You can refer to the
:module:`FeatureSummary` instead.
> + set_package_properties(${dep} PROPERTIES TRANSITIVE_DEPENDENCY)
I prefer not to create public API in set_package_properties for something
that doesn't need to be public. find_dependency() should be all the public
API needed.
I counter-propose the FeatureSummary-no-transitive topic which I just
pushed. What do you think?
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=a6971f651
Thanks,
Steve.
More information about the cmake-developers
mailing list