[cmake-developers] [PATCH 0/4] XCTest Bundles v2

[Brad King]

On 12/16/2014 04:22 PM, Gregor Jasny wrote:
> I addressed all the comments you gave about the last series.

Thanks.  I've applied the first two patches since they are
independent cleanups and merged for testing:

 cmTarget: Use GetCFBundleDirectory within GetFullNameInternal
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=207b7af0

 Xcode: Call IsCFBundleOnApple to decide if bundle is being built
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3a605693

> * if a fatal error is issued in cmGlobalXCodeGenerator::CreateBuildSettings
>   generation does not stop. So you'll see the error for every configuration.

FATAL_ERROR messages are meant to stop the configuration step.
The generation step is different for every generator so one
would need custom code to avoid the duplicate warning.

However, in this case the XCTEST_HOST checking is an aspect of
the project specification and not of the Xcode generator.  These
checks should be done somewhere at the beginning of generation.
You could hook in to cmGlobalGenerator::Generate just after the
call to FinalizeTargetCompileInfo, for example.

With that you should be able to add tests somewhere in the
Tests/RunCMake/ infrastructure to cover these error messages
on all platforms.

> * Hooking up CocoaExample into test suite. Note: This is an Cocoa application,
>   so it needs a valid display session.

Does this mean it cannot run in a cron job?  Or just that the user must
be logged in?

Thanks,
-Brad