[cmake-developers] [PATCH] VS, WINCE: Fix entry point for Unicode builds
Bach, Pascal
pascal.bach at siemens.com
Tue Dec 9 10:46:31 EST 2014
> On 12/09/2014 09:45 AM, Bach, Pascal wrote:
> > the old behavior was better. The user should then be able to set the
> > entry point independent of the UNICODE setting via a target property.
> > This would be similar to how WIN32_EXECUTABLE selects WinMain as
> startup.
>
> Good catch. They are orthogonal settings. I've reverted the change:
>
> Revert "VS, WINCE: Fix entry point for Unicode builds"
> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=df01a380
>
> Unfortunately original change is in the v3.1.0-rc3 tag. This is
> why I don't like taking non-regression changes after the feature
> freeze for a release. I took it because I thought it was a bug
> in the new WinCE support. Now we need to revert it from the
> release branch too. Still, better than finding this after the
> release and needing a policy to fix it.
Sorry for that. I thought of it as a bug too.
Just after a discussion today with a colleague I realized it is not really the case.
Is there a place where we could document things like this in the CMake documentation? Something like a platform specific collection of best practice and commonly required tasks.
Maybe the Wiki would also be a good place for that.
Pascal
More information about the cmake-developers
mailing list