[cmake-developers] suggestion: rename FindXerces to FindXercesC

Roger Leigh rleigh at codelibre.net
Thu Dec 4 17:54:35 EST 2014


On Thu, Dec 04, 2014 at 10:32:53AM -0500, Brad King wrote:
> On 12/04/2014 10:09 AM, Erik Sjölund wrote:
> > I think it is a good idea to rename FindXerces to FindXercesC or
> > something similar, just to indicate that is about the C++
> > implementation.
> 
> Thanks for pointing out the distinct implementations.  The module
> is new in CMake 3.1 so our last chance to rename it now before the
> final release of that version.  Actually it looks like we're missing
> a release note for it too.
> 
> The documentation of the module starts off with:
> 
>  "Find the Apache Xerces-C++ validating XML parser..."
> 
> which is pretty clear, though that is not visible at the call
> sites of find_package(Xerces).
> 
> Roger, as the contributor of this module do you have any reason
> not to change the name?

No.  Either is fine with me; I didn't expect this to be problematic
to omit the C suffix, but happy to have it added if it will avoid
confusion.

I just saw your other mail saying you'd made a patch.  Do you need me
to do anything else?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


More information about the cmake-developers mailing list